Add error response parsing for restXml #922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewyz
force-pushed
the
joewyz/restxml-error-parse-fix
branch
from
d30c5e3 to
78d0aca
Compare
mtdowling
requested changes
Nov 13, 2025
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Outdated
Show resolved
Hide resolved
mtdowling
requested changes
Nov 13, 2025
| * @param source Response payload source | ||
| * @return String value of the Code element if found | ||
| */ | ||
| public String parseCodeName(ByteBuffer source) { |
Member
There was a problem hiding this comment.
This seems out of place on XmlCodec. Maybe move to XmlDeserializer.
Contributor
Author
There was a problem hiding this comment.
XmlDeserializer is package private and we cannot access it if we put it to XmlDeserializer. I think XmlCodec is the only public class under this package, so I put the method here.
codecs/xml-codec/src/main/java/software/amazon/smithy/java/xml/XmlCodec.java
Outdated
Show resolved
Hide resolved
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Outdated
Show resolved
Hide resolved
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Show resolved
Hide resolved
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Outdated
Show resolved
Hide resolved
...client-http/src/main/java/software/amazon/smithy/java/client/http/HttpErrorDeserializer.java
Outdated
Show resolved
Hide resolved
codecs/xml-codec/src/main/java/software/amazon/smithy/java/xml/XmlDeserializer.java
Show resolved
Hide resolved
codecs/xml-codec/src/main/java/software/amazon/smithy/java/xml/XmlDeserializer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation for restXml could not parse the error response because the HttpErrorDeserializer is converting the response to document which is not supported in restXml. This PR adds a fix for this to pass protocol tests "InvalidGreetingError" and "ComplexError".
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.